lostluck commented on code in PR #35337:
URL: https://github.com/apache/beam/pull/35337#discussion_r2153038463
##########
sdks/go/pkg/beam/runners/prism/internal/stage.go:
##########
@@ -224,8 +224,11 @@ progress:
slog.Debug("splitting report", "bundle", rb,
"index", index)
sr, err := b.Split(ctx, wk, 0.5 /* fraction of
remainder */, nil /* allowed splits */)
if err != nil {
- slog.Warn("SDK Error from split,
aborting splits", "bundle", rb, "error", err.Error())
- break progress
+ slog.Warn("SDK Error from split,
aborting splits and failing bundle", "bundle", rb, "error", err.Error())
+ if b.BundleErr != nil {
+ b.BundleErr = err
+ }
+ return b.BundleErr
Review Comment:
Splits are allowed to fail, but not fail the bundle. eg. "I can't apply that
split" is valid, but are not bundle failing.
Similar to the above, this should stop the progTicks and wait until the
bundle and data to complete first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
