nguymin4 commented on code in PR #35388:
URL: https://github.com/apache/beam/pull/35388#discussion_r2193407144
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -1174,6 +1174,16 @@ def is_docker_available():
return True
+ def is_docker_compose_v2_available():
+ cmd = ['docker', 'compose', 'version']
+
+ try:
+ subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
Review Comment:
@tvalentyn I have no strong opinion about this. I currently put it here as
it's quite clear about the checking steps: java -> docker -> docker compose.
But I think it's ok to put it inside `transform_service_launcher.py` as well
Should I make the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
