tvalentyn commented on code in PR #35388:
URL: https://github.com/apache/beam/pull/35388#discussion_r2195432395
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -1174,6 +1174,16 @@ def is_docker_available():
return True
+ def is_docker_compose_v2_available():
+ cmd = ['docker', 'compose', 'version']
+
+ try:
+ subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
Review Comment:
I am not very familiar with the control flow here and didn't look very
closely, but if we can infer the settings closer to where docker is invoked,
that seems preferable to plumbing along the setting through a few calls in the
stack.
We do need to make sure that the code where we check for docker settings is
running in the envrionment that has docker, where the command will actually be
running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
