shunping commented on code in PR #34612:
URL: https://github.com/apache/beam/pull/34612#discussion_r2205030567
##########
sdks/python/apache_beam/io/fileio_test.py:
##########
@@ -106,7 +106,7 @@ def test_match_files_one_directory_failure1(self):
files.append(self._create_temp_file(dir=directories[0]))
files.append(self._create_temp_file(dir=directories[0]))
- with self.assertRaises(beam.io.filesystem.BeamIOError):
+ with self.assertRaises(Exception):
Review Comment:
When a Runtime Exception is raised in prism, maybe we can improve this to
use
[assertRaisesRegex](https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaisesRegex)
instead to match exception message? Just like some example in
`sdks/python/apache_beam/ml/inference/pytorch_inference_test.py` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
