shunping commented on code in PR #34612:
URL: https://github.com/apache/beam/pull/34612#discussion_r2205077410
##########
sdks/python/apache_beam/runners/direct/direct_runner.py:
##########
@@ -136,41 +176,40 @@ def visit_transform(self, applied_ptransform):
if userstate.is_stateful_dofn(dofn):
# https://github.com/apache/beam/issues/32786 -
# Remove once Real time clock is used.
- _, timer_specs = userstate.get_dofn_specs(dofn)
+ state_specs, timer_specs = userstate.get_dofn_specs(dofn)
for timer in timer_specs:
if timer.time_domain == TimeDomain.REAL_TIME:
self.supported_by_prism_runner = False
- tryingPrism = False
+ for state in state_specs:
+ if isinstance(state, userstate.CombiningValueStateSpec):
+ self.supported_by_prism_runner = False
+ # TODO(https://github.com/apache/beam/issues/33623): Prism seems to
Review Comment:
Interesting, I recently fixed a bug when prism handles sliding window
(#35385). Just want to reference here in case it is related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
