shunping commented on code in PR #34612:
URL: https://github.com/apache/beam/pull/34612#discussion_r2205071338
##########
sdks/python/apache_beam/runners/direct/direct_runner.py:
##########
@@ -112,9 +118,25 @@ def visit_transform(self, applied_ptransform):
class _PrismRunnerSupportVisitor(PipelineVisitor):
"""Visitor determining if a Pipeline can be run on the PrismRunner."""
- def accept(self, pipeline):
+ def accept(self, pipeline, is_interactive):
+ all_options = options.get_all_options()
self.supported_by_prism_runner = True
- pipeline.visit(self)
+ # TODO(https://github.com/apache/beam/issues/33623): Prism currently
+ # double fires on AfterCount trigger, once appropriately, and once
+ # incorrectly at the end of the window. This if condition could be
+ # more targeted, but for now we'll just ignore all unsafe triggers.
+ if pipeline.allow_unsafe_triggers:
+ self.supported_by_prism_runner = False
+ # TODO(https://github.com/apache/beam/issues/33623): Prism currently
Review Comment:
What else problems do we have here for prism to run in interactive mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
