damccorm commented on code in PR #35954:
URL: https://github.com/apache/beam/pull/35954#discussion_r2301049927
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -58,35 +58,45 @@ env:
jobs:
beam_PreCommit_Python_Coverage:
- name: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- runs-on: [self-hosted, ubuntu-20.04, highmem]
+ name: ${{ matrix.job_name }} (${{ matrix.job_phrase }} ${{
matrix.python_version }})
Review Comment:
Instead of including python_version, could we include the os? That way the
generated job names will be different per job
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -110,6 +120,12 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:tox:py39:preCommitPyCoverage
+ arguments: |
+ -Pposargs="${{
+ contains(matrix.os, 'self-hosted') &&
+ '-m (not require_docker_in_docker)' ||
+ '-m require_docker_in_docker'
Review Comment:
This currently fails with exit code 5 when `require_docker_in_docker` is
set. That means that no tests are being run. To avoid this problem, could we
add this as part of https://github.com/apache/beam/pull/35920 instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
