mohamedawnallah commented on code in PR #35954:
URL: https://github.com/apache/beam/pull/35954#discussion_r2301643578
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -110,6 +120,12 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:tox:py39:preCommitPyCoverage
+ arguments: |
+ -Pposargs="${{
+ contains(matrix.os, 'self-hosted') &&
+ '-m (not require_docker_in_docker)' ||
+ '-m require_docker_in_docker'
Review Comment:
> This currently fails with exit code 5 when `require_docker_in_docker` is
set. That means that no tests are being run. To avoid this problem, could we
add this as part of #35920 instead?
It failed since previously added `ubuntu-latest` on the `matrix.os` to run
this workflow on. But after this
(https://github.com/apache/beam/pull/35954#issuecomment-3221946977) it should
run only on the self-hosted and tests marked with `require_docker_in_docker`
wouldn't be triggered so not getting this exit code 5.
The main issue for this is there are tests already marked with
`require_docker_in_docker` but since milvus not added properly as extra
dependency it is skipped:
https://github.com/apache/beam/blob/f2b38cd5625500b379667e624a6935a904a7cfd1/sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py#L472
https://github.com/apache/beam/blob/f2b38cd5625500b379667e624a6935a904a7cfd1/sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py#L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
