mohamedawnallah commented on code in PR #35954:
URL: https://github.com/apache/beam/pull/35954#discussion_r2305172484
##########
.github/workflows/beam_PreCommit_Python_Coverage.yml:
##########
@@ -110,6 +120,12 @@ jobs:
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:test-suites:tox:py39:preCommitPyCoverage
+ arguments: |
+ -Pposargs="${{
+ contains(matrix.os, 'self-hosted') &&
+ '-m (not require_docker_in_docker)' ||
+ '-m require_docker_in_docker'
Review Comment:
> Yeah, agreed on the issue. I would recommend including this with #35920 so
that:
>
> 1. I'm able to test the whole thing together as a single unit
> 2. If we merge and/or roll back, we don't risk causing this workflow to
fail while we wait for [[bugFix] sdks/python: properly add Milvus as extra
dependency #35920](https://github.com/apache/beam/pull/35920) to go in
>
> Basically it allows us to treat this as a single atomic change which is
helpful
Good point. Removed `Pposargs` 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
