Abacn commented on code in PR #35981:
URL: https://github.com/apache/beam/pull/35981#discussion_r2317192967
##########
settings.gradle.kts:
##########
@@ -372,3 +372,7 @@ include("sdks:java:io:iceberg:bqms")
findProject(":sdks:java:io:iceberg:bqms")?.name = "bqms"
include("it:clickhouse")
findProject(":it:clickhouse")?.name = "clickhouse"
+include("sdks:java:extensions:sql:iceberg")
+findProject(":sdks:java:extensions:sql:iceberg")?.name = "iceberg"
+include("examples:java:iceberg")
+findProject(":examples:java:iceberg")?.name = "iceberg"
Review Comment:
We also need to add `sql/iceberg` module to sqlprecommit and sqlpostcommit:
https://github.com/apache/beam/blob/1de583037dc57bde439104b74bea4b3a5ada0d04/build.gradle.kts#L377
https://github.com/apache/beam/blob/1de583037dc57bde439104b74bea4b3a5ada0d04/build.gradle.kts#L425
and also add examples/iceberg module to java precommit, and if any examples
also get exercised in postcommit test, we need to add it there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
