ahmedabu98 commented on code in PR #35981:
URL: https://github.com/apache/beam/pull/35981#discussion_r2322746284
##########
settings.gradle.kts:
##########
@@ -372,3 +372,7 @@ include("sdks:java:io:iceberg:bqms")
findProject(":sdks:java:io:iceberg:bqms")?.name = "bqms"
include("it:clickhouse")
findProject(":it:clickhouse")?.name = "clickhouse"
+include("sdks:java:extensions:sql:iceberg")
+findProject(":sdks:java:extensions:sql:iceberg")?.name = "iceberg"
+include("examples:java:iceberg")
+findProject(":examples:java:iceberg")?.name = "iceberg"
Review Comment:
Looks like both `beam_PreCommit_SQL_Java8` and `beam_PreCommit_SQL_Java17`
are directly running `./gradlew sdks:java:extensions:sql:preCommit`:
https://github.com/apache/beam/blob/32d53ab22e5a2d8fe40750fce6ccbf737718d974/.github/workflows/beam_PreCommit_SQL_Java17.yml#L93
Should be fine though because the Iceberg tests are getting picked up by the
`beam_PreCommit_SQL` workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
