Abacn commented on code in PR #35981:
URL: https://github.com/apache/beam/pull/35981#discussion_r2323226973
##########
settings.gradle.kts:
##########
@@ -372,3 +372,7 @@ include("sdks:java:io:iceberg:bqms")
findProject(":sdks:java:io:iceberg:bqms")?.name = "bqms"
include("it:clickhouse")
findProject(":it:clickhouse")?.name = "clickhouse"
+include("sdks:java:extensions:sql:iceberg")
+findProject(":sdks:java:extensions:sql:iceberg")?.name = "iceberg"
+include("examples:java:iceberg")
+findProject(":examples:java:iceberg")?.name = "iceberg"
Review Comment:
> We currently don't have any tests for examples
The `build` task will still compile the module regardless there is test or
not. If not add `:examples:iceberg` to JavaPreCommit we won't notice when there
is compile error introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
