tkaymak opened a new pull request, #38489: URL: https://github.com/apache/beam/pull/38489
Small follow-up to PR #38255 (`[runners-spark] Add Spark 4 runner`) addressing the two review comments left at the approved/merged head SHA that weren't folded in before merge. ## Changes 1. **Restore `CHANGES.md` `feature Y added to Java SDK` placeholder line** — lost to a rebase; reinstated verbatim. Addresses [`r3204237226`](https://github.com/apache/beam/pull/38255#discussion_r3204237226). 2. **Delete two orphaned `.github/trigger_files/*.json`** — addresses [`r3204241059`](https://github.com/apache/beam/pull/38255#discussion_r3204241059): - `beam_PreCommit_Java_Spark4_Versions.json` — its workflow YAML was deleted in #38255. - `beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json` — flagged as "not effective yet"; since the comment was written, #38478 renamed the associated workflow YAML to `beam_PostCommit_Java_ValidatesRunner_Spark4.yml`, so this trigger JSON is doubly orphaned. The renamed workflow YAML stays in place — per the trigger-files convention, these JSONs are only added when an author wants to manually trigger a specific PostCommit. ## Verification - Local `:validateChanges` passes (build successful, "CHANGES.md validation successful"). R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
