tkaymak commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236515238
##########
.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json:
##########
@@ -1,3 +0,0 @@
-{
Review Comment:
Thanks @gemini-code-assist, but my read of @Abacn's guidance on #38453 is
that we don't add stub trigger JSONs for new workflow YAMLs. Quoting his reply
on #38453 (https://github.com/apache/beam/pull/38453#discussion_r3225387943):
> I've seen a few occurrences AI-assisted PRs keep adding trigger file json
for new workflow addition, which is not necessary. Creation or modification of
trigger file is only needed when the PR author want to trigger a specific
PostCommit manually.
So the deletion here removes a doubly-orphaned file (workflow YAML deleted
in #38255, then renamed in #38478), and we deliberately do not add a
`beam_PostCommit_Java_ValidatesRunner_Spark4.json` replacement. Manual
triggering still works via the standard `Run Java_ValidatesRunner_Spark4
PostCommit` comment phrase that the workflow YAML defines; the trigger JSON is
only one of several activation paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
