gemini-code-assist[bot] commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236486596
##########
.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json:
##########
@@ -1,3 +0,0 @@
-{
Review Comment:
The PR description mentions that the associated workflow was renamed to
`beam_PostCommit_Java_ValidatesRunner_Spark4.yml`. In the Beam repository,
these trigger files are used by the CI system to allow manual triggering of
jobs via GitHub comments (e.g., for ValidatesRunner tests). Deleting this file
without providing a replacement with the new name
(`beam_PostCommit_Java_ValidatesRunner_Spark4.json`) will break the ability for
contributors to manually trigger these tests. It is recommended to rename the
file to match the new workflow name instead of just deleting it.
##########
CHANGES.md:
##########
@@ -60,6 +60,7 @@
## Highlights
* New highly anticipated feature X added to Python SDK
([#X](https://github.com/apache/beam/issues/X)).
+* New highly anticipated feature Y added to Java SDK
([#Y](https://github.com/apache/beam/issues/Y)).
Review Comment:
While restoring the placeholder is helpful for future entries, the Spark 4
runner (added in #38255) is a significant feature that should be explicitly
listed in the 'Highlights' section of `CHANGES.md`. Consider adding a specific
entry for it here to ensure it is properly announced in the release notes.
```suggestion
* New highly anticipated feature Y added to Java SDK
([#Y](https://github.com/apache/beam/issues/Y)).
* Spark 4 runner added to Java SDK
([#38255](https://github.com/apache/beam/pull/38255)).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
