sjvanrossum commented on code in PR #39297:
URL: https://github.com/apache/beam/pull/39297#discussion_r3574352375
##########
build.gradle.kts:
##########
@@ -1056,3 +1056,22 @@ if (project.hasProperty("testJavaVersion")) {
}
}
}
+
+subprojects {
Review Comment:
For reference,
https://github.com/apache/beam/pull/39284/changes/875ad91b7cb30452a15477d03eb9f238ea57f2cc
shows the ripple of capability conflicts after upgrading Kafka to 3.9.2.
Running the `dependencies` task on all subprojects doesn't catch all new
capability conflicts since the conflicts in Nexmark and TPC-DS don't show up
until you specify `-Pnexmark.runner` or `-Ptpcds.runner` and go through
`:runners:flink:1.19`, `:runners:flink:1.20`, `:runners:flink:2.1`,
`:runners:flink:2.2`,`:runners:spark:3` and `:runners:spark:4`.
If I'm not mistaken, the Nexmark and TPC-DS failures would not have been
caught by the Github actions running against #39284.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
