sjvanrossum commented on code in PR #39297:
URL: https://github.com/apache/beam/pull/39297#discussion_r3577195261
##########
build.gradle.kts:
##########
@@ -1056,3 +1056,22 @@ if (project.hasProperty("testJavaVersion")) {
}
}
}
+
+subprojects {
Review Comment:
It's not a direct dependency in any subproject and only a transitive
dependency outside of core (Flink, Kafka and Spark afaik).
To my understanding, the proposed changes would alter release artifacts when:
- A subproject adds a direct dependency on `org.lz4:lz4-java` and is
compiled as a regular JAR, altering the POM to include `at.yawk.lz4:lz4-java`.
- A subproject adds a shadowed (direct or transitive) dependency on
`org.lz4:lz4-java` and is compiled as a fat JAR, altering the bundled classes
to include `at.yawk.lz4:lz4-java`.
Under ideal circumstances the former would be flagged and corrected during
review.
The latter is slightly more difficult to reason about, but as far as I can
tell by grepping for `configuration:\s+['"]shadow` there are no subprojects
with shadowed dependencies that include a transitive dependency on
`org.lz4:lz4-java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
