[GitHub] [beam] milancermak commented on pull request #12953: Minor programming guide improvements

[GitBox]

milancermak commented on pull request #12953:
URL: https://github.com/apache/beam/pull/12953#issuecomment-703108161


   Hi, thank you for the review.
   
   Since Figure 3 pertains to an unbounded collection, to me it makes sense to 
me to have a KafkaIO transform there. I've changed the diagram so that it reads 
from a Kafka topic instead of a database table. That we the text doesn't have 
to updated either. Here's the before & after. 
   
   <img width="1104" alt="windowing-pipeline-unbounded-before" 
src="https://user-images.githubusercontent.com/184055/94993430-73b31100-0580-11eb-92ef-2ab0c4d37058.png";>
   <img width="1117" alt="windowing-pipeline-unbounded-after" 
src="https://user-images.githubusercontent.com/184055/94993431-757cd480-0580-11eb-80c9-1347a7dc355d.png";>
   
   
   What do you think?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org