shunping commented on code in PR #40579:
URL: https://github.com/apache/beam/pull/40579#discussion_r4284463653
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -507,6 +546,9 @@ static void configureOpenTelemetry(PipelineOptions options)
{
void setOpenTelemetry(OpenTelemetry value);
class GlobalOpenTelemetryFactory implements
DefaultValueFactory<OpenTelemetry> {
+ private static final Pattern SECRET_PLACEHOLDER_PATTERN =
+ Pattern.compile("\\$\\{(type:[^}]+)\\}");
Review Comment:
This pattern requires type: to be at the very beginning of the secret option
string, but Secret.parseSecretOption doesn't actually enforce that restriction.
Have you considered making the regex more flexible to match the parser's
behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
