shunping commented on code in PR #40579:
URL: https://github.com/apache/beam/pull/40579#discussion_r4286814442
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -499,6 +510,33 @@ static void configureOpenTelemetry(PipelineOptions
options) {
}
}
+ /**
+ * Resolves any inline {@code ${...}} secret placeholders in an
OpenTelemetry property value using
+ * {@link Secret#parseSecretOption(String)}.
+ */
+ @VisibleForTesting
+ static String resolveOpenTelemetryPropertyValue(String value) {
Review Comment:
Yes, I agree. Moving this logic to a generic utility alongside Secret would
be a great way to ensure we handle this consistently across IOs that accept a
map of configuration, like icebergIO and kafkaIO.
This PR also highlights that using an inline secret string format is much
more user-friendly than attempting to parse nested JSON. However, I am afraid
this will confuse users since in some places we support JSON secret spec and
others support inline secret string.
Do you consider it as a problem @damccorm ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
