damccorm commented on code in PR #40579:
URL: https://github.com/apache/beam/pull/40579#discussion_r4286667449
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java:
##########
@@ -499,6 +510,33 @@ static void configureOpenTelemetry(PipelineOptions
options) {
}
}
+ /**
+ * Resolves any inline {@code ${...}} secret placeholders in an
OpenTelemetry property value using
+ * {@link Secret#parseSecretOption(String)}.
+ */
+ @VisibleForTesting
+ static String resolveOpenTelemetryPropertyValue(String value) {
Review Comment:
I wonder if this would be better as a generic function packaged in util
alongside `Secret`? Right now, it is just used by OpenTelemetry, but I could
imagine it being broadly useful, and it would be nice to make sure we do this
consistently.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
