mxtymoshyk commented on code in PR #40850:
URL: https://github.com/apache/beam/pull/40850#discussion_r4548840256
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/WorkProgressUpdater.java:
##########
@@ -315,7 +316,11 @@ private void reportProgress() {
throw oom;
} catch (InterruptedException e) {
LOG.info("Cancelling workitem execution: {}", workString(), e);
- worker.abort();
+ // the batch worker reports progress while the executor is still being
created, before
+ // there is a worker to abort
+ if (Objects.nonNull(worker)) {
Review Comment:
Switched to `!= null`.
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java:
##########
Review Comment:
Removed.
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkProgressUpdater.java:
##########
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
