mxtymoshyk commented on code in PR #40850:
URL: https://github.com/apache/beam/pull/40850#discussion_r4548864711


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WorkItemStatusClient.java:
##########


Review Comment:
   Removed. Most of it is just for the checker: a few parameters and 
`uniqueWorkId` became `@Nullable`, and `worker` and `executionContext` are read 
into locals before the null checks. In `reportError` the checker treats 
`UserCodeException.getCause()` as possibly null, so the message is now set only 
when `formatException` returns one. Nothing changes at runtime: a 
`UserCodeException` always has a cause, and setting a null message was the same 
as not setting one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to