mxtymoshyk commented on code in PR #40850:
URL: https://github.com/apache/beam/pull/40850#discussion_r4548895583
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/BatchDataflowWorker.java:
##########
@@ -286,14 +296,30 @@ boolean doWork(WorkItem workItem, WorkItemStatusClient
workItemStatusClient) thr
}
workItemStatusClient.setWorker(worker, executionContext);
- DataflowWorkProgressUpdater progressUpdater =
- new DataflowWorkProgressUpdater(workItemStatusClient, workItem,
worker, options);
- executeWork(worker, progressUpdater);
+ if (Objects.isNull(progressUpdater)) {
Review Comment:
It's null for source operation work items, like splitting a source. Those
don't create DoFns, so only map tasks start the updater before the executor is
built. Source operations keep the old order: create the executor, then the
updater, then call `executeWork`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
