PawasChhokra commented on a change in pull request #14945:
URL: https://github.com/apache/beam/pull/14945#discussion_r676739851
##########
File path: runners/samza/src/test/resources/ExpectedDag.json
##########
@@ -0,0 +1,103 @@
+{
+ "RootNode": [
+ { "fullName":"OuterMostNode",
+ "shortName":"OuterMostNode",
+ "id":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues",
+ "shortName":"Create.TimestampedValues",
+ "id":"Create.TimestampedValues",
+ "enclosingNode":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues/Create.Values",
+ "shortName":"Create.Values",
+ "id":"Create.TimestampedValues/Create.Values",
+ "enclosingNode":"Create.TimestampedValues",
+ "ChildNode":[
+ {
"fullName":"Create.TimestampedValues/Create.Values/Read(CreateSource)",
+ "shortName":"Read(CreateSource)",
Review comment:
Yes we should keep it since we display the short name in the DAG and the
full name information is shown once the user clicks the node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
