PawasChhokra commented on a change in pull request #14945:
URL: https://github.com/apache/beam/pull/14945#discussion_r681049274
##########
File path: runners/samza/src/test/resources/ExpectedDag.json
##########
@@ -0,0 +1,103 @@
+{
+ "RootNode": [
+ { "fullName":"OuterMostNode",
+ "shortName":"OuterMostNode",
+ "id":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues",
+ "shortName":"Create.TimestampedValues",
+ "id":"Create.TimestampedValues",
+ "enclosingNode":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues/Create.Values",
+ "shortName":"Create.Values",
+ "id":"Create.TimestampedValues/Create.Values",
+ "enclosingNode":"Create.TimestampedValues",
+ "ChildNode":[
+ {
"fullName":"Create.TimestampedValues/Create.Values/Read(CreateSource)",
+ "shortName":"Read(CreateSource)",
Review comment:
So this name is the same name that the PTransform creates for itself,
and this implementation comes with a default value which could be overridden.
Hence, I would like to keep it as is. This is how we get the shortName for now:
`node.getTransform().getName()` as opposed to the fullName which refers another
field: `node.getFullName()`. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
