PawasChhokra commented on a change in pull request #14945:
URL: https://github.com/apache/beam/pull/14945#discussion_r681048652
##########
File path: runners/samza/src/test/resources/ExpectedDag.json
##########
@@ -0,0 +1,103 @@
+{
+ "RootNode": [
+ { "fullName":"OuterMostNode",
+ "shortName":"OuterMostNode",
+ "id":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues",
+ "shortName":"Create.TimestampedValues",
+ "id":"Create.TimestampedValues",
+ "enclosingNode":"OuterMostNode",
+ "ChildNode":[
+ { "fullName":"Create.TimestampedValues/Create.Values",
+ "shortName":"Create.Values",
+ "id":"Create.TimestampedValues/Create.Values",
+ "enclosingNode":"Create.TimestampedValues",
Review comment:
I think keeping the enclosingNode as another field makes the code much
more cleaner and readable on the front end side, hence we should keep this as
is. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
