jrmccluskey commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847711123
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -77,8 +77,7 @@ var (
teardownPolicy = flag.String("teardown_policy", "", "Job teardown
policy (internal only).")
// SDK options
- cpuProfiling = flag.String("cpu_profiling", "", "Job records CPU
profiles to this GCS location (optional)")
- sessionRecording = flag.String("session_recording", "", "Job records
session transcripts")
Review Comment:
We'll have to double-check this, but the sessionRecording flag currently
does nothing (hence the removed empty branch and removed flag) so I removed it.
But it is, technically, a breaking change since someone could be running
dataflow jobs with this flag set even though it doesn't do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
