lostluck commented on code in PR #17340:
URL: https://github.com/apache/beam/pull/17340#discussion_r847746921
##########
sdks/go/pkg/beam/runners/dataflow/dataflow.go:
##########
@@ -77,8 +77,7 @@ var (
teardownPolicy = flag.String("teardown_policy", "", "Job teardown
policy (internal only).")
// SDK options
- cpuProfiling = flag.String("cpu_profiling", "", "Job records CPU
profiles to this GCS location (optional)")
- sessionRecording = flag.String("session_recording", "", "Job records
session transcripts")
Review Comment:
Technically it's likely to fix the job unless it's been very small (outside
of breaking the flag being present).
The session runner's job was an honest hearted attempt to make SDK
development and bug finding easier by allowing playback of recorded job
features in the Early Portability age. These days, it's better if we have
clearer tools for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
