viirya commented on code in PR #424:
URL: https://github.com/apache/datafusion-comet/pull/424#discussion_r1600500642
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -738,6 +738,17 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateTimestamps(), DataTypes.DateType)
}
+ // todo: Refactor this
+ test("xxhash64") {
+ val input = generateStrings(timestampPattern, 8).toDF("a")
+ withTempPath { dir =>
+ val data = roundtripParquet(input, dir).coalesce(1)
+ data.createOrReplaceTempView("t")
+ val df = spark.sql(s"select a, xxhash64(a), xxhash64(1, a) from t order
by a")
+ checkSparkAnswerAndOperator(df)
+ }
+ }
Review Comment:
Hmm, this is randomly generated, how do we make sure it definitely produces
the data causing the error? Could we have a deterministic test case for the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
