viirya commented on code in PR #424:
URL: https://github.com/apache/datafusion-comet/pull/424#discussion_r1600518058
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -104,66 +108,110 @@ fn test_murmur3() {
let _expected = vec![
142593372, 1485273170, -97053317, 1322437556, -396302900, 814637928,
];
+ assert_eq!(_hashes, _expected)
Review Comment:
We can remove `_` from `_hashes` and `_expected`. I am not sure why we don't
compare them before, seems to disable the test so they are prefixed with `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
