alamb commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1600615522
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -90,13 +92,63 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
name,
args,
over,
- distinct,
filter,
- null_treatment,
- special: _, // true if not called with trailing parens
- order_by,
+ mut null_treatment,
+ within_group,
} = function;
+ // todo handle case when args is none (for current_timestamp)
+ let FunctionArguments::List(args) = args else {
+ return not_impl_err!("Unsupported function argument {args:?}");
+ };
+
+ let FunctionArgumentList {
Review Comment:
I took a shot at handling the changes to argument handling here (due to
https://github.com/sqlparser-rs/sqlparser-rs/pull/1247)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
