tisonkun commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1599294528
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -943,11 +950,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
) => GetFieldAccess::NamedStructField {
name: ScalarValue::from(s),
},
- SQLExpr::JsonAccess {
- left,
- operator: JsonOperator::Colon,
- right,
- } => {
+ SQLExpr::JsonAccess { value, path } => {
Review Comment:
@alamb @jmhain, do you have ideas on how we should modify this branch now?
Previously, we handled `xxx::yyy` in this branch. But now,
`JsonOperator::Colon` no longer exists.
It seems to me that we should handle `path.len() == 1` or `path.len() == 2`
and build a `GetFieldAccess::ListRange` as the original logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
