alamb commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1600648484
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -895,111 +844,75 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let args = vec![fullstr, substr];
Ok(Expr::ScalarFunction(ScalarFunction::new_udf(fun, args)))
}
- fn sql_agg_with_filter_to_expr(
Review Comment:
there is no special sqlparser struct for this kind of aggregate function
anymore -- it is all unified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
