jayzhan211 commented on code in PR #10560:
URL: https://github.com/apache/datafusion/pull/10560#discussion_r1605052852
##########
datafusion/functions-aggregate/src/macros.rs:
##########
@@ -48,49 +48,98 @@ macro_rules! make_udaf_expr_and_func {
None,
))
}
+
+ create_builder!(
+ $EXPR_FN,
+ $($arg)*,
+ $DOC,
+ $AGGREGATE_UDF_FN
+ );
+
create_func!($UDAF, $AGGREGATE_UDF_FN);
};
- ($UDAF:ty, $EXPR_FN:ident, $($arg:ident)*, $distinct:ident, $DOC:expr,
$AGGREGATE_UDF_FN:ident) => {
Review Comment:
I plan to introduce another macro for distinct, so we have `count_distinct`,
`count_distinct_builder` expr::fn.
I change to `order_by` because `first_value` needs it. Also, I change the
expression for `first_value` to single expression, since it does not expect
variadic args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
