alamb commented on code in PR #10560: URL: https://github.com/apache/datafusion/pull/10560#discussion_r1605497952
########## datafusion/proto/tests/cases/roundtrip_logical_plan.rs: ########## @@ -31,8 +31,10 @@ use datafusion::datasource::TableProvider; use datafusion::execution::context::SessionState; use datafusion::execution::runtime_env::{RuntimeConfig, RuntimeEnv}; use datafusion::execution::FunctionRegistry; -use datafusion::functions_aggregate::covariance::{covar_pop, covar_samp}; -use datafusion::functions_aggregate::expr_fn::first_value; +use datafusion::functions_aggregate::expr_fn::{ Review Comment: Could we add some documentation with examples somewhere? That would both serve to help document and test this feature. But thank you @jayzhan211 -- this is looking very cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org