goldmedal commented on issue #10557: URL: https://github.com/apache/datafusion/issues/10557#issuecomment-2118721347
Provide something I surveyed. I think we can follow how Calcite handles the quoted issue. The `SqlDialect` of Calcite has a check rule `identifierNeedsQuote`. https://github.com/apache/calcite/blob/aba64f0b217093b500629fe07a0befdc68293fbc/core/src/main/java/org/apache/calcite/sql/SqlDialect.java#L413-L415 It can be overridden according to the specific data source, such as BigQuery: https://github.com/apache/calcite/blob/50a20824c4536450dcae963b5e757cf4bbc7e406/core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java#L106-L109 They implement some rules, such as regex patterns or reserved word lists. I think a dialect-specific rule is a nice choice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
