goldmedal commented on issue #10557: URL: https://github.com/apache/datafusion/issues/10557#issuecomment-2118875053
> https://github.com/sqlparser-rs/sqlparser-rs/blob/54184460b5d873a67c2801e8b7c6e4f145bc65df/src/dialect/mod.rs#L113-L116 > > The dialect specific implementations just need to be expanded on. For now they just always return a conservative quote character. I think it's same as the dialect in datafusion::unparser::dialect https://github.com/apache/datafusion/blob/e7858ff0ab1c282ab46bd93cabc3dc83db583165/datafusion/sql/src/unparser/dialect.rs#L28 However, what we need is a checker to check if the identifier needs to be quoted. I think I can make a PR for `DefaultDialect` first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
