alamb commented on PR #10623: URL: https://github.com/apache/datafusion/pull/10623#issuecomment-2126718060
Thank you @phillipleblanc > Is that something you generally do for all builder-type APIs, or it depends? I would say it depends. In this case I hadd a use case for `add` style in the example I am working on for indexing (you can see this in action here https://github.com/apache/datafusion/pull/10618) However, I can see how we could do something else in this case, so perhaps I should remove the `set` style APIs 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
