alamb commented on code in PR #10623:
URL: https://github.com/apache/datafusion/pull/10623#discussion_r1610405386
##########
datafusion-examples/examples/csv_opener.rs:
##########
@@ -58,16 +57,11 @@ async fn main() -> Result<()> {
let path = std::path::Path::new(&path).canonicalize()?;
- let scan_config = FileScanConfig {
- object_store_url: ObjectStoreUrl::local_filesystem(),
- file_schema: schema.clone(),
- file_groups:
vec![vec![PartitionedFile::new(path.display().to_string(), 10)]],
- statistics: Statistics::new_unknown(&schema),
- projection: Some(vec![12, 0]),
- limit: Some(5),
- table_partition_cols: vec![],
- output_ordering: vec![],
- };
+ let scan_config =
Review Comment:
This is a pretty good example of what the new API allows for:
1. Less code (defaults are set)
2. Makes it clearer what is the default and what is not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
