alamb commented on code in PR #10623:
URL: https://github.com/apache/datafusion/pull/10623#discussion_r1611564907
##########
datafusion/core/src/datasource/physical_plan/file_scan_config.rs:
##########
@@ -64,12 +64,43 @@ pub fn wrap_partition_value_in_dict(val: ScalarValue) ->
ScalarValue {
/// The base configurations to provide when creating a physical plan for
/// any given file format.
+///
+/// # Example
+/// ```
+/// # use std::sync::Arc;
+/// # use arrow_schema::Schema;
+/// use datafusion::datasource::listing::PartitionedFile;
+/// # use datafusion::datasource::physical_plan::FileScanConfig;
+/// # use datafusion_execution::object_store::ObjectStoreUrl;
Review Comment:
🤔 maybe I should change this example to use the with style 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
