advancedxy commented on code in PR #424: URL: https://github.com/apache/datafusion-comet/pull/424#discussion_r1616472369
########## spark/inspections/CometTPCHQueriesList-results.txt: ########## @@ -1,142 +1,129 @@ Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometFilter, CometProject) Query: q1 TPCH Snappy: ExplainInfo: -Shuffle: unsupported Spark partitioning: org.apache.spark.sql.catalyst.plans.physical.RangePartitioning +Comet shuffle is not enabled: spark.sql.adaptive.coalescePartitions.enabled is enabled and spark.comet.shuffle.enforceMode.enabled is not enabled Review Comment: @parthchandra I don't have enough compute resources to test against 1TB dataset. So, this and the TPCDS result are generated directly from running `org.apache.spark.sql.CometTPCHQueriesList/CometTPCDSQueriesList` locally without modifications. It seems a lot of `explain` info has been updated, do you think these changes are reasonable or due to missing some configurations in the scripts. it would be great that if you could rerun the inspection with this PR or should we update the script to maintain the up-to-date configurations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
