parthchandra commented on code in PR #424:
URL: https://github.com/apache/datafusion-comet/pull/424#discussion_r1621538973


##########
spark/inspections/CometTPCHQueriesList-results.txt:
##########
@@ -1,142 +1,129 @@
 Query: q1 TPCH Snappy. Comet Exec: Enabled (CometHashAggregate, CometFilter, 
CometProject)
 Query: q1 TPCH Snappy: ExplainInfo:
-Shuffle: unsupported Spark partitioning: 
org.apache.spark.sql.catalyst.plans.physical.RangePartitioning
+Comet shuffle is not enabled: spark.sql.adaptive.coalescePartitions.enabled is 
enabled and spark.comet.shuffle.enforceMode.enabled is not enabled

Review Comment:
   The changes to explain info occur because Spark generates different plans at 
different scales (especially wrt to broadcast). 
   Let me run with this PR and get an updated version. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to