comphead commented on code in PR #455:
URL: https://github.com/apache/datafusion-comet/pull/455#discussion_r1616497338
##########
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##########
@@ -54,16 +57,79 @@ class CometExpressionCoverageSuite extends CometTestBase
with AdaptiveSparkPlanH
private val valuesPattern = """(?i)FROM VALUES(.+?);""".r
private val selectPattern = """(i?)SELECT(.+?)FROM""".r
+ // exclude funcs Comet has no plans to support streaming in near future
+ // like spark streaming functions, java calls
+ private val outofRoadmapFuncs =
+ List("window", "session_window", "window_time", "java_method", "reflect")
+ private val sqlConf = Seq(
+ "spark.comet.exec.shuffle.enabled" -> "true",
+ "spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding",
+ "spark.sql.adaptive.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding")
+
+ // Tests to run manually as its syntax is different from usual or nested
+ val manualTests: Map[String, (String, String)] = Map(
+ "!" -> ("select true a", "select ! true from tbl"),
+ "%" -> ("select 1 a, 2 b", "select a + b from tbl"),
Review Comment:
Corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
