advancedxy commented on code in PR #455:
URL: https://github.com/apache/datafusion-comet/pull/455#discussion_r1616589501
##########
spark/src/test/scala/org/apache/comet/CometExpressionCoverageSuite.scala:
##########
@@ -217,6 +325,25 @@ class CometExpressionCoverageSuite extends CometTestBase
with AdaptiveSparkPlanH
str shouldBe s"${getLicenseHeader()}\n# Supported Spark Expressions\n\n###
group1\n - [x] f1\n - [ ] f2\n\n### group2\n - [x] f3\n - [ ] f4\n\n###
group3\n - [x] f5"
}
+ test("get sql function arguments") {
+ // getSqlFunctionArguments("SELECT unix_seconds(TIMESTAMP('1970-01-01
00:00:01Z'))") shouldBe Seq("TIMESTAMP('1970-01-01 00:00:01Z')")
+ // getSqlFunctionArguments("SELECT decode(unhex('537061726B2053514C'),
'UTF-8')") shouldBe Seq("unhex('537061726B2053514C')", "'UTF-8'")
+ // getSqlFunctionArguments("SELECT extract(YEAR FROM TIMESTAMP '2019-08-12
01:00:00.123456')") shouldBe Seq("'YEAR'", "TIMESTAMP '2019-08-12
01:00:00.123456'")
+ // getSqlFunctionArguments("SELECT exists(array(1, 2, 3), x -> x % 2 ==
0)") shouldBe Seq("array(1, 2, 3)")
+ getSqlFunctionArguments("select to_char(454, '999')") shouldBe
Seq("array(1, 2, 3)")
Review Comment:
hmmm, i think it should be updated to
```scala
getSqlFunctionArguments("select to_char(454, '999')") shouldBe Seq(454,
"999")
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
