alamb commented on code in PR #10696:
URL: https://github.com/apache/datafusion/pull/10696#discussion_r1617756810
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -72,7 +72,7 @@ impl Default for FirstValue {
impl FirstValue {
pub fn new() -> Self {
Self {
- aliases: vec![String::from("first_value")],
+ aliases: vec![],
Review Comment:
A minor comment is we can probably remove the `aliases` field entirely and
just return an empty slice
```rust
fn aliases(&self) -> &[String] {
&[]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
