jayzhan211 commented on code in PR #10696:
URL: https://github.com/apache/datafusion/pull/10696#discussion_r1618012266
##########
datafusion/functions-aggregate/src/lib.rs:
##########
@@ -109,13 +109,13 @@ mod tests {
let mut names = HashSet::new();
for func in all_default_aggregate_functions() {
assert!(
- names.insert(func.name().to_string()),
+ names.insert(func.name().to_string().to_lowercase()),
Review Comment:
Can we not convert to lowercase here? If someone changes the name to
uppercase again, the function in the function map (lowercase) is not the same
as the function name (uppercase), and it is easy to introduce a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
