tisonkun commented on PR #10392: URL: https://github.com/apache/datafusion/pull/10392#issuecomment-2143340101
@alamb there is even a new breaking change at https://github.com/sqlparser-rs/sqlparser-rs/pull/1272: ``` error[E0277]: the trait bound `Arc<str>: From<Box<sqlparser::ast::Expr>>` is not satisfied --> datafusion/sql/src/expr/mod.rs:578:74 | 578 | DataType::Timestamp(TimeUnit::Nanosecond, Some(time_zone.into())), | ^^^^ the trait `From<Box<sqlparser::ast::Expr>>` is not implemented for `Arc<str>`, which is required by `Box<sqlparser::ast::Expr>: Into<_>` | = help: the following other types implement trait `From<T>`: <Arc<str> as From<&str>> <Arc<str> as From<std::string::String>> = note: required for `Box<sqlparser::ast::Expr>` to implement `Into<Arc<str>>` ``` I'm worried about downstream projects to upgrade datafusion now 🤣 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
