MohamedAbdeen21 commented on code in PR #10832:
URL: https://github.com/apache/datafusion/pull/10832#discussion_r1632036676
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -696,7 +696,8 @@ impl<'n> TreeNodeVisitor<'n> for ExprIdentifierVisitor<'_> {
return Ok(TreeNodeRecursion::Jump);
}
- self.id_array.push((0, "".to_string()));
+ self.id_array
Review Comment:
To be completely honest, having it in the first traversal made the most
sense to me, you may have noticed that the initial commit even used the
`VisitStack`. But I like your suggestion better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
