MohamedAbdeen21 commented on code in PR #10832:
URL: https://github.com/apache/datafusion/pull/10832#discussion_r1632038405
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -782,9 +786,11 @@ impl TreeNodeRewriter for CommonSubexprRewriter<'_> {
return Ok(Transformed::new(expr, false, TreeNodeRecursion::Jump));
}
- let (up_index, expr_id) = &self.id_array[self.down_index];
+ let (up_index, expr_id, aliased) = &self.id_array[self.down_index];
self.down_index += 1;
+ self.aliased |= aliased;
Review Comment:
No, we don't need to alias any children of an Alias.Other rules deal with
the parent/main expression and its alias, not the children/nested exprs.
I don't get what you mean by nodes other than the ancestor. The rewriter is
called on single exprs, not the entire plan at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
